Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix two new panic detected #1573

Merged
merged 2 commits into from
May 24, 2023
Merged

fix two new panic detected #1573

merged 2 commits into from
May 24, 2023

Conversation

mrpalide
Copy link
Contributor

Did you run make format && make check? Yes

Fixes #1572

Changes:

  • add condition on whitelistPKs list creating in initDmsgHTTPLogServer
  • fix panic on skywire-cli proxy start <pk> command

How to test this PR:
_

0pcom
0pcom approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@0pcom 0pcom merged commit f9a42a7 into skycoin:develop May 24, 2023
@mrpalide mrpalide deleted the fix/proxy-command-initdmsghttpserver-logic branch March 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0pcom 0pcom 0pcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrpalide @0pcom